Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add advitise address in cloudcore #1643

Merged
merged 2 commits into from
May 11, 2020
Merged

add advitise address in cloudcore #1643

merged 2 commits into from
May 11, 2020

Conversation

fisherxu
Copy link
Member

@fisherxu fisherxu commented May 8, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Xref: #1642

Todo: Update the docs in follow-up PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add advitise address in cloudcore

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels May 8, 2020
@fisherxu fisherxu requested a review from kadisi May 8, 2020 03:11
@fisherxu fisherxu mentioned this pull request May 8, 2020
Closed
4 tasks
@kevin-wangzefeng
Copy link
Member

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@kevin-wangzefeng
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020
@kubeedge-bot kubeedge-bot merged commit 11bed9c into kubeedge:master May 11, 2020
@fisherxu fisherxu mentioned this pull request May 15, 2020
Merged
kubeedge-bot added a commit that referenced this pull request May 15, 2020
@kubeedge-bot
Merge pull request #1673 from fisherxu/automated-cherry-pick-of-#1643…
7f5a89f 
…-upstream-release-1.3

Automated cherry pick of #1643: add advitise address in cloudcore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@kuramal kuramal Awaiting requested review from kuramal

@kadisi kadisi Awaiting requested review from kadisi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisherxu @kevin-wangzefeng @kubeedge-bot