Support for init container #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 11, 2019 12:53
Signed-off-by: iamrz1 <[email protected]>
Signed-off-by: iamrz1 <[email protected]>
Signed-off-by: iamrz1 <[email protected]>
tamalsaha
reviewed
Mar 12, 2019
| @@ -19,166 +19,178 @@ spec: | |||
| apiVersion: catalog.kubedb.com/v1alpha1 | |||
| kind: ElasticsearchVersion | |||
| metadata: | |||
| name: "5.6-v1" | |||
There was a problem hiding this comment.
Why was this one deleted? In general avoid making unrelated changes in a pr.
tamalsaha
requested changes
Mar 12, 2019
There was a problem hiding this comment.
Also update the chart https://github.com/kubedb/cli/tree/master/chart/kubedb-catalog/templates
added 5 commits
March 13, 2019 11:21
Signed-off-by: iamrz1 <[email protected]>
Signed-off-by: iamrz1 <[email protected]>
the-redback
suggested changes
Mar 13, 2019
There was a problem hiding this comment.
We may need to add initcontainers in deprecated versions too.
Otherwise, it will throw error while installation and user will get panicked.
Error from server (Invalid): error when creating "STDIN": MongoDBVersion.catalog.kubedb.com "3.6-v1" is invalid: []: Invalid value: map[string]interface {}{"spec":map[string]interface {}{"db":map[string]interface {}{"image":"maruftuhin/mongo:3.6-v1"}, "deprecated":true, "exporter":map[string]interface {}{"image":"maruftuhin/mongodb_exporter:v1.0.0"}, "tools":map[string]interface {}{"image":"maruftuhin/mongo-tools:3.6-v2"}, "version":"3.6"}, "apiVersion":"catalog.kubedb.com/v1alpha1", "kind":"MongoDBVersion", "metadata":map[string]interface {}{"creationTimestamp":"2019-03-13T08:54:46Z", "labels":map[string]interface {}{"app":"kubedb"}, "annotations":map[string]interface {}{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"catalog.kubedb.com/v1alpha1\",\"kind\":\"MongoDBVersion\",\"metadata\":{\"annotations\":{},\"labels\":{\"app\":\"kubedb\"},\"name\":\"3.6-v1\"},\"spec\":{\"db\":{\"image\":\"maruftuhin/mongo:3.6-v1\"},\"deprecated\":true,\"exporter\":{\"image\":\"maruftuhin/mongodb_exporter:v1.0.0\"},\"tools\":{\"image\":\"maruftuhin/mongo-tools:3.6-v2\"},\"version\":\"3.6\"}}\n"}, "generation":1, "uid":"a6d688e5-456d-11e9-8014-080027a0a2ce", "name":"3.6-v1"}}: validation failure list:
spec.initContainer in body is required
tamalsaha
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iamrz1 [email protected]