Added DBVersions default objects && Removed '--docker-registry' and '--exporter-tag' from operator flags #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion & RedisVersion default objects
the-redback
changed the title
the-redback
changed the title
--docker-registry and --exporter-tag from operator flags
the-redback
changed the title
--docker-registry and --exporter-tag from operator flags
tamalsaha
requested changes
Aug 13, 2018
| @@ -36,8 +36,6 @@ spec: | |||
| args: | |||
| - run | |||
| - --v=3 | |||
| - --docker-registry={{ .Values.kubedb.registry }} | |||
There was a problem hiding this comment.
Should be removed from chart values.yaml, README.md
There was a problem hiding this comment.
used in Operator Deployment. https://github.com/kubedb/cli/blob/add-catalog/chart/kubedb/templates/deployment.yaml#L34
| @@ -26,8 +26,6 @@ spec: | |||
| args: | |||
| - run | |||
| - --v=3 | |||
| - --docker-registry=${KUBEDB_DOCKER_REGISTRY} | |||
There was a problem hiding this comment.
Do we need these env vars anymore?
There was a problem hiding this comment.
we will need this for operator image registry. https://github.com/kubedb/cli/pull/259/files#diff-fe75a3dbc397c302725732de654e0290L24
tamalsaha
reviewed
Aug 14, 2018
hack/deploy/kubedb.sh
Outdated
| echo "adding kubedb catalog" | ||
| case "$KUBEDB_ENABLE_CATALOG" in | ||
| all) | ||
| ${SCRIPT_LOCATION}hack/deploy/kubedb-catalog/* | $ONESSL envsubst | kubectl apply -f - |
There was a problem hiding this comment.
This will not work. This will return 404 .
tamalsaha
force-pushed
the
add-catalog
branch
2 times, most recently
from
db50e05 to
d77891e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--docker-registry&--exporter-tagfrom operator flags--ignore-not-found=trueistead of|| true