-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubedb catalog #256
Add kubedb catalog #256
Conversation
Should I update the docs in this PR as well? |
release: "{{ .Release.Name }}" | ||
spec: | ||
db: | ||
image: "kubedb/postgres:9.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a values.yaml with an option to specify registry . Example: https://github.com/kubedb/cli/blob/master/chart/kubedb/values.yaml#L6
This will allow someone using a private registry to update the image properly.
Please do. |
For the non helm install would you like me to use something like sed to get the registry into that yaml? |
You can use the Installer script: YAML: |
@tamalsaha I have some rough pages for the docs. Let me know if there is anyway i can do these better. |
hack/deploy/kubedb-catalog.yaml
Outdated
db: | ||
image: "${KUBEDB_DOCKER_REGISTRY}/postgres:9.6.7" | ||
exporter: | ||
image: "${KUBEDB_DOCKER_REGISTRY}/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
The exporter is part of the combined operator .
hack/deploy/kubedb-catalog.yaml
Outdated
db: | ||
image: "${KUBEDB_DOCKER_REGISTRY}/postgres:9.6" | ||
exporter: | ||
image: "${KUBEDB_DOCKER_REGISTRY}/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
hack/deploy/kubedb-catalog.yaml
Outdated
db: | ||
image: "${KUBEDB_DOCKER_REGISTRY}/postgres:10.2" | ||
exporter: | ||
image: "${KUBEDB_DOCKER_REGISTRY}/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
@@ -92,7 +92,7 @@ spec: | |||
|
|||
Here, | |||
|
|||
- `spec.version` is the version of PostgreSQL database. In this tutorial, a PostgreSQL 9.6 database is created. | |||
- `spec.version` is name of the PostgresVersion crd where the docker images exist. In this tutorial, a PostgreSQL 9.6 database is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docker images are specified
The best way to create a custom image is to build ontop of the existing kubedb image | ||
|
||
```docker | ||
FROM kubedb/postgres:10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a unreleased note to this pr, should we create a github.com/kubedb/timescaledb
repo and just include the docker files and add then to the catalog ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that sounds like a good idea
db: | ||
image: "{{ .Values.docker-registry }}/postgres:9.6" | ||
exporter: | ||
image: "{{ .Values.docker-registry }}/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
db: | ||
image: "{{ .Values.docker-registry }}/postgres:9.6.7" | ||
exporter: | ||
image: "{{ .Values.docker-registry }}/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
db: | ||
image: "{{ .Values.docker-registry }}/postgres:10.2" | ||
exporter: | ||
image: "{{ .Values.docker-registry }}/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
chart/kubedb-catalog/values.yaml
Outdated
@@ -0,0 +1 @@ | |||
docker-registry: "kubedb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: dockerRegistry
docs_0.8.0: | ||
identifier: pg-custom-versions-setup-postgres | ||
name: HA Setup | ||
parent: pg-custom-versions-postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Overview
|
||
## Creating a Custom Postgres Database Image for KubeDB | ||
|
||
The best way to create a custom image is to build ontop of the existing kubedb image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: on top
(space)
period.
(missing .)
db: | ||
image: "myco/postgres:10.2-timescale" | ||
exporter: | ||
image: "kubedb/pg-operator:0.8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator:0.8.0
apiVersion: kubedb.com/v1alpha1 | ||
kind: PostgresVersion | ||
metadata: | ||
name: timescale-10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. Should this be timescale-0.9.1
?
Signed-off-by: Joshua Benjamin <[email protected]>
Signed-off-by: Joshua Benjamin [email protected]