Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubedb catalog #256

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Add kubedb catalog #256

merged 1 commit into from
Aug 3, 2018

Conversation

annymsMthd
Copy link
Contributor

Signed-off-by: Joshua Benjamin [email protected]

@annymsMthd
Copy link
Contributor Author

Should I update the docs in this PR as well?

release: "{{ .Release.Name }}"
spec:
db:
image: "kubedb/postgres:9.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a values.yaml with an option to specify registry . Example: https://github.com/kubedb/cli/blob/master/chart/kubedb/values.yaml#L6

This will allow someone using a private registry to update the image properly.

@tamalsaha
Copy link
Member

Should I update the docs in this PR as well?

Please do.

@annymsMthd
Copy link
Contributor Author

For the non helm install would you like me to use something like sed to get the registry into that yaml?

@tamalsaha
Copy link
Member

You can use the onessl tool we use. The main reason is we can download on a machine without needing sudo. It has a onessl envsubst command that behaves like envsubst from gettext package.

Installer script:
https://github.com/kubedb/cli/blob/master/hack/deploy/kubedb.sh#L351

YAML:
https://github.com/kubedb/cli/blob/master/hack/deploy/operator.yaml#L24

@annymsMthd
Copy link
Contributor Author

@tamalsaha I have some rough pages for the docs. Let me know if there is anyway i can do these better.

db:
image: "${KUBEDB_DOCKER_REGISTRY}/postgres:9.6.7"
exporter:
image: "${KUBEDB_DOCKER_REGISTRY}/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db:
image: "${KUBEDB_DOCKER_REGISTRY}/postgres:9.6"
exporter:
image: "${KUBEDB_DOCKER_REGISTRY}/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator:0.8.0

db:
image: "${KUBEDB_DOCKER_REGISTRY}/postgres:10.2"
exporter:
image: "${KUBEDB_DOCKER_REGISTRY}/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator:0.8.0

@@ -92,7 +92,7 @@ spec:

Here,

- `spec.version` is the version of PostgreSQL database. In this tutorial, a PostgreSQL 9.6 database is created.
- `spec.version` is name of the PostgresVersion crd where the docker images exist. In this tutorial, a PostgreSQL 9.6 database is created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docker images are specified

The best way to create a custom image is to build ontop of the existing kubedb image

```docker
FROM kubedb/postgres:10.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a unreleased note to this pr, should we create a github.com/kubedb/timescaledb repo and just include the docker files and add then to the catalog ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds like a good idea

db:
image: "{{ .Values.docker-registry }}/postgres:9.6"
exporter:
image: "{{ .Values.docker-registry }}/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator:0.8.0

db:
image: "{{ .Values.docker-registry }}/postgres:9.6.7"
exporter:
image: "{{ .Values.docker-registry }}/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator:0.8.0

db:
image: "{{ .Values.docker-registry }}/postgres:10.2"
exporter:
image: "{{ .Values.docker-registry }}/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator:0.8.0

@@ -0,0 +1 @@
docker-registry: "kubedb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: dockerRegistry

docs_0.8.0:
identifier: pg-custom-versions-setup-postgres
name: HA Setup
parent: pg-custom-versions-postgres
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: Overview


## Creating a Custom Postgres Database Image for KubeDB

The best way to create a custom image is to build ontop of the existing kubedb image
Copy link
Member

@tamalsaha tamalsaha Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: on top (space)

period. (missing .)

db:
image: "myco/postgres:10.2-timescale"
exporter:
image: "kubedb/pg-operator:0.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator:0.8.0

apiVersion: kubedb.com/v1alpha1
kind: PostgresVersion
metadata:
name: timescale-10.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. Should this be timescale-0.9.1 ?

Signed-off-by: Joshua Benjamin <[email protected]>
@tamalsaha tamalsaha merged commit 6795776 into kubedb:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants