Implement "kubedb get" #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2017 17:04
sadlil
approved these changes
May 1, 2017
tamalsaha
reviewed
May 1, 2017
glide.yaml
Outdated
| @@ -4,3 +4,7 @@ import: | |||
| - package: github.com/appscode/log | |||
| - package: k8s.io/kubernetes | |||
| version: ~1.5.0 | |||
| - package: github.com/spf13/cobra | |||
| version: 9c28e4bbd74e5c3ed7aacbc552b2cab7cfdfe744 | |||
glide.yaml
Outdated
| - package: github.com/spf13/cobra | ||
| version: 9c28e4bbd74e5c3ed7aacbc552b2cab7cfdfe744 | ||
| - package: github.com/spf13/pflag | ||
| version: c7e63cf4530bcd3ba943729cee0efeff2ebea63f |
pkg/kube/config.go
Outdated
| @@ -0,0 +1,16 @@ | |||
| package kube | |||
pkg/kube/client.go
Outdated
| } | ||
|
|
||
| // New create a new Client | ||
| func GetKubeCmd(cmd *cobra.Command) *Client { |
pkg/cmd/get.go
Outdated
| }, | ||
| } | ||
|
|
||
| util.AddContextFlag(cmd) |
There was a problem hiding this comment.
This should be a persistent flag
docs/kubedb/get.md
Outdated
| replicas: 1 | ||
| serviceAccountName: governing-elasticsearch | ||
| version: 2.3.1-v2.3 | ||
| status: |
There was a problem hiding this comment.
status:
DatabaseStatus: Running
creationTime: 2017-04-27T04:46:52Z
This looks inconsistent.
There was a problem hiding this comment.
DatabaseStatus should be lowe camel like other. Also, I think kube uses the word phase.
status:
phase: Running
``
tamalsaha
added a commit
that referenced
this pull request
Jul 8, 2018
5e13446a shfmt -l -w -ci -i 2 *.sh 499a1ab8 Add kubeware script 8e0811f8 Add kubevault script f1cf7f24 Rename kiteci to kubeci 0e54dac9 Use go 1.9 compiler since tar package breaks static build 7117c1b8 Add soter image a1aad737 Update README.md eb754899 Mount /.cache folder to /tmp dcf8ff35 Don't use upx with Windows binaries f1197df8 Update README.md 6e94151a Use Golang 1.10.0-alpine 2bd987dd Add kubepack script bf8075a7 Update Golang to 1.9.4 2634f8cc Keep the original file when bzip2-ing f38a25e0 Use bzip2 without tar 21306b4c Fix upx command 17b0826f Fix compress process 068e6317 Conditionally enable upx dd8f2507 Stop using upx a40fdcb1 Use zip to compress in windows 7aea4cbb Update libbuild.py 59c194c2 Create *.tar.bz2 archives (#17) 53cabf10 Compress Go binaries using upx (#16) 81dd7359 only update canary tags for images built from master branch (#14) c21c4816 Switch to GO 1.9.3 f0faa64b Remove `-it` from docker builds 430a90bc Use kiteci/golang:1.9.2-alpine image fc9db855 Add kiteci.sh 55918b96 Add pharmer script d8ec9c74 Update to go 1.9.2 alpine image 4c4d9152 Use Docker hub for public images f1e269ab Update alpine image to 1.9.1 7b029988 Set GOBIN var c409b02a Use current user to build alpine image. b70065d4 Add build command for alpine (#12) 27220cfa Update libbuild.py git-subtree-dir: hack/libbuild git-subtree-split: 5e13446ab1012269f7c3ba914dbf93a399db41ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.