Add editor role to SAML RBAC #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjayTripathy
approved these changes
May 26, 2022
| @@ -173,6 +173,11 @@ saml: | |||
| assertionName: "http://schemas.auth0.com/userType" | |||
| assertionvalues: | |||
| - "readonly" | |||
| - name: editor | |||
| enabled: true # if editor is enabled, editors will be allowed to edit reports/alerts scoped to them, and act as readers otherwise. Users will never default to editor. | |||
There was a problem hiding this comment.
Might start with this false? otherwise LGTM
There was a problem hiding this comment.
Ah yep, should be false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds the editor role to
values.saml.rbac.groups. More information on the behavior of this role can be found in the linked KCCM PR.Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
Have you made an update to documentation?