-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make types
on AdmissionRequest
and AdmissionResponse
public
#977
Conversation
Was making writing serde-less unit tests more difficult then they had to be. Oversight that it was left private. See #976 Signed-off-by: clux <[email protected]>
There is actually one slight downside to doing this though... By making these types pub, it is easier for users to construct invalid
The However, leaving them private means people can only unit test |
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
+ Coverage 72.35% 72.37% +0.02%
==========================================
Files 64 64
Lines 4438 4438
==========================================
+ Hits 3211 3212 +1
+ Misses 1227 1226 -1
|
Signed-off-by: clux <[email protected]>
Have added a little more documentation on the admission flow, I think it's actually pretty good already. If people wishes to construct the types manually in controllers then it's going against what the documentation says (which now at every step mentions the main path). The documentation does not mention manually constructing types at all. |
AdmissionRequest::types
publicAdmissionRequest::types
and AdmissionResponse::types
public
AdmissionRequest::types
and AdmissionResponse::types
publictypes
field on AdmissionRequest
and AdmissionResponse
public
types
field on AdmissionRequest
and AdmissionResponse
publictypes
on AdmissionRequest
and AdmissionResponse
public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sounds OK, we're already exposing all of K8s' usual objects in all their gory detail (via k8s-openapi).
…blic (kube-rs#977)" This reverts commit bf885f0.
Was making writing serde-less unit tests for admission controller input more difficult then they had to
be. Oversight that it was left private. See #976