Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence false positive significant_drop_in_scrutinee for SplitCase #931

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 8, 2022

Fixes #930

This should ensure that we get a compile error if any temporary is even borrowed past the poll_next() call.

No need to include this in the changelog since it's purely an internal rephrasing (and Clippy ignores external dependencies).

Fixes kube-rs#930

This should ensure that we get a compile error if any temporary is even borrowed
past the `poll_next()` call.
@nightkr nightkr added the runtime controller runtime related label Jun 8, 2022
@nightkr nightkr requested review from clux and a team June 8, 2022 09:36
@nightkr nightkr self-assigned this Jun 8, 2022
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, lol, that's enough huh

@clux clux added the changelog-exclude changelog excluded prs label Jun 8, 2022
@clux clux added this to the 0.74.0 milestone Jun 8, 2022
@clux clux merged commit d4c9f5d into kube-rs:master Jun 8, 2022
@nightkr nightkr deleted the bugfix/issue-930 branch June 8, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs runtime controller runtime related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential deadlock in SpitCase impl Stream
2 participants