Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path to Result in derives #795

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 26, 2022

Fixes #794

@nightkr nightkr added bug Something isn't working derive kube-derive proc_macro related changelog-fix changelog fix category for prs labels Jan 26, 2022
@nightkr nightkr requested a review from a team January 26, 2022 16:12
@nightkr nightkr self-assigned this Jan 26, 2022
@nightkr
Copy link
Member Author

nightkr commented Jan 26, 2022

cc @danrspencer

@nightkr nightkr force-pushed the bugfix/absolute-result branch from c6b5123 to d23eeb5 Compare January 26, 2022 16:12
Fixes kube-rs#794

Signed-off-by: Teo Klestrup Röijezon <[email protected]>
@nightkr nightkr force-pushed the bugfix/absolute-result branch from d23eeb5 to 85858ef Compare January 26, 2022 16:16
@codecov-commenter
Copy link

Codecov Report

Merging #795 (85858ef) into master (3d5f90d) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   72.01%   72.03%   +0.02%     
==========================================
  Files          55       55              
  Lines        3727     3730       +3     
==========================================
+ Hits         2684     2687       +3     
  Misses       1043     1043              
Impacted Files Coverage Δ
kube-derive/src/custom_resource.rs 12.80% <66.66%> (+1.00%) ⬆️
kube-runtime/src/wait.rs 70.00% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5f90d...85858ef. Read the comment docs.

@clux clux added this to the 0.68.0 milestone Jan 26, 2022
@nightkr nightkr merged commit 18b5316 into kube-rs:master Jan 26, 2022
@nightkr nightkr deleted the bugfix/absolute-result branch January 26, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog-fix changelog fix category for prs derive kube-derive proc_macro related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomResource derive macro is rendering an unqualified Result
4 participants