Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Dashmap to 3.11.7 to fix store duplicates #287

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jul 23, 2020

Fixes #286. Also adds an example for testing the the new kube_runtime::reflector, and a regression test.

You can repro the original issue by cherry-picking 5c700ea on top of the current master (38e5698).

@nightkr
Copy link
Member Author

nightkr commented Jul 23, 2020

This removes Store::iter for now, because the interface is really unstable and will break once we upgrade back to dashmap 4.x (hopefully after the official release, this time around :P).

@clux clux merged commit b0fd4e9 into kube-rs:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflector store sometimes stores multiple instances of the same object
2 participants