Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured kubeconfig errors #237

Merged
merged 3 commits into from
May 8, 2020
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented May 7, 2020

This makes the errors introspectable, which makes things like https://github.com/yaahc/color-eyre/ much nicer. It also allows you to inspect the error contents (though this API probably shouldn't be considered very stable..).

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks a lot better. Always in favour of having better error handling.

@clux
Copy link
Member

clux commented May 7, 2020

Although fails when building with rustls on ci ^

@clux clux merged commit 5a69e42 into kube-rs:master May 8, 2020
@nightkr nightkr deleted the feature/structured-errors branch May 8, 2020 17:03
@clux
Copy link
Member

clux commented May 8, 2020

Released in 0.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants