-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick and merge oauth2 progress from ynqa #20
Conversation
If neither of `certificate-authority-data` or `certificate_authority` is set, do not try to load a root CA for the client.
cherry-picked and merged from ynqa/kubernetes-rust@9633021
cherry-picked from ynqa/kubernetes-rust@b237b75
Just wanted to comment that the other changes in this PR work quite nicely on my AWS EKS clusters. I was able to run the
|
That's really helpful. Thanks a lot. I'll probably just speculatively merge this branch then for the next release. Unfortunately, I don't have an EKS cluster at hand to really verify with yet, but I can probably leave that part of the code-base alone for a while. |
I've managed to make this branch compile with up to date master by doing a bunch of manual Error conversions. Will try to improve it later. In the mean time, any chance you could see if this branch still works for you on EKS @stephenmuss ? [dependencies]
kube = { git = "https://github.com/clux/kube-rs", rev = "8b7a0b832b04965027a639010c420bd2cc3a5bfa" } |
The branch doesn't work for me after the merge. I get the following errors with the node_reflector and pod_reflector. $ cargo run --example node_reflector
Compiling kube v0.12.0 (/Users/steve/code/rs/kube-rs)
error[E0599]: no function or associated item named `v1Node` found for type `kube::api::typed::Api<_>` in the current scope
--> examples/node_reflector.rs:14:25
|
14 | let resource = Api::v1Node(client);
| ^^^^^^ function or associated item not found in `kube::api::typed::Api<_>`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0599`.
error: Could not compile `kube`.
To learn more, run the command again with --verbose. $ cargo run --example pod_reflector
Compiling kube v0.12.0 (/Users/steve/code/rs/kube-rs)
error[E0599]: no function or associated item named `v1Pod` found for type `kube::api::typed::Api<_>` in the current scope
--> examples/pod_reflector.rs:14:25
|
14 | let resource = Api::v1Pod(client).within(&namespace);
| ^^^^^ function or associated item not found in `kube::api::typed::Api<_>`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0599`.
error: Could not compile `kube`.
To learn more, run the command again with --verbose. With an empty cargo project I also get an error with just this in Cargo.toml [dependencies]
kube = { git = "https://github.com/clux/kube-rs", rev = "8b7a0b832b04965027a639010c420bd2cc3a5bfa" }
|
I think that's just the missing feature. How about: [dependencies]
kube = { git = "https://github.com/clux/kube-rs", rev = "8b7a0b832b04965027a639010c420bd2cc3a5bfa", features = ["openapi"] }
k8s-openapi = { version = "0.4.0", features = ["v1_13"] } We changed this interface for #44 so we can explicitly choose what k8s-openapi dependency variant we want. If you are running the examples in here directly try running with the examples with |
👍 Yep, that did the trick. Examples work and new cargo project looks good too. |
Awesome. Thanks a lot. I'll clean up a few unrelated things and try to merge this ASAP. |
Released in kube 0.13.0 |
Compiles, but crashes on the clusters I have with third party providers, so will have to visit it later. Help would be appreciated here.
See #19 for discussion.