Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose Config::load - closes #124 #125

Merged
merged 5 commits into from
Feb 9, 2020
Merged

expose Config::load - closes #124 #125

merged 5 commits into from
Feb 9, 2020

Conversation

clux
Copy link
Member

@clux clux commented Feb 9, 2020

perhaps we should not allow a custom path?

perhaps we should not allow a custom path?
@mattsawyer77
Copy link

It might be nice to also include the means for finding the path to the kube config file based on env vars, etc.

@clux
Copy link
Member Author

clux commented Feb 9, 2020

It might be nice to also include the means for finding the path to the kube config file based on env vars, etc.

Agreed, I am considering exposing the one in utils, or attaching it to Config

@clux clux merged commit d035193 into master Feb 9, 2020
@clux clux deleted the config-load branch February 9, 2020 20:35
@mattsawyer77
Copy link

@clux thanks so much! it's working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants