Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a ? so that getting pod logs works #107

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Added a ? so that getting pod logs works #107

merged 1 commit into from
Dec 27, 2019

Conversation

bloveless
Copy link
Contributor

I noticed that getting the pod logs doesn't work and that seems to be because there is no ? at the end of the log url.

So I added one.

clux
clux approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clux clux merged commit 2a335b3 into kube-rs:master Dec 27, 2019
@clux
Copy link
Member

clux commented Dec 31, 2019

Released in kube 0.23.0 🙂

@bloveless
Copy link
Contributor Author

Awesome! Thanks for the update!

@bloveless bloveless deleted the fix-getting-pod-logs branch December 31, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bloveless @clux