Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: port wait for NamesAccepted logit to use kube_runtime await_condition #655

Closed
clux opened this issue Oct 17, 2021 · 1 comment · Fixed by #659
Closed

example: port wait for NamesAccepted logit to use kube_runtime await_condition #655

clux opened this issue Oct 17, 2021 · 1 comment · Fixed by #659
Assignees
@clux
Labels
runtime controller runtime related

Comments

@clux
Copy link
Member

clux commented Oct 17, 2021 •
edited
Loading

See https://github.com/kube-rs/kube-rs/blob/master/examples/crd_apply.rs#L82-L109 for the logic that we used to copy pasted a few places (also in crd_derive_schema.rs).

The old logic waiting for the NamesAccepted condition deserves a rewrite to use kube_runtime's new await_condition.

If it feels useful, a helper fn inside conditions would also be useful
@clux clux added help wanted Not immediately prioritised, please help! good first issue Good for newcomers runtime controller runtime related labels Oct 17, 2021
@clux clux mentioned this issue Oct 17, 2021
Merged
@clux clux removed help wanted Not immediately prioritised, please help! good first issue Good for newcomers labels Oct 18, 2021
@clux clux self-assigned this Oct 18, 2021
@clux
Copy link
Member Author

clux commented Oct 18, 2021

Got a WIP for this opening a separate PR.

clux added a commit that referenced this issue Oct 18, 2021
@clux
add conditions::is_accepted for crds - closes #655
fe94f59 
Signed-off-by: clux <[email protected]>
@clux clux linked a pull request Oct 18, 2021 that will close this issue
conditions::is_accepted for crds with await_condition #659
Merged
clux added a commit that referenced this issue Oct 20, 2021
@clux
conditions::is_accepted for crds with await_condition (#659)
55d7018 
* add conditions::is_accepted for crds - closes #655

Signed-off-by: clux <[email protected]>

* rename to established based on new information + timout guard

Signed-off-by: clux <[email protected]>

* simplify a bit

Signed-off-by: clux <[email protected]>

* traitify condition

Signed-off-by: clux <[email protected]>

* docs for Condition fn trait

Signed-off-by: clux <[email protected]>

* add example for await_condition as well

Signed-off-by: clux <[email protected]>

* fix pedantic lints

Signed-off-by: clux <[email protected]>
@clux clux closed this as completed in 8effb4f Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clux clux

Labels
runtime controller runtime related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

conditions::is_accepted for crds with await_condition kube-rs/kube
1 participant
@clux