Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate kube::runtime #281

Closed
nightkr opened this issue Jul 21, 2020 · 2 comments · Fixed by #282
Closed

Deprecate kube::runtime #281

nightkr opened this issue Jul 21, 2020 · 2 comments · Fixed by #282
Labels
runtime controller runtime related

Comments

@nightkr
Copy link
Member

nightkr commented Jul 21, 2020

Replaced by kube_runtime crate.
@clux clux added the runtime controller runtime related label Jul 21, 2020
@clux
Copy link
Member

clux commented Jul 21, 2020

Yeah, go for it.

Was waiting a bit until I felt confident in the a crate split solution first. From last comment in #204 it feels like we should have either 2 crates (kube (incl runtime) + derive) or 5 crates (1 master exporter crate + config/client + derive + runtime).

If we go for the former, then kube-runtime should replace the current one on the same export path. I guess in either case, a deprecation warning is needed.

@nightkr
Copy link
Member Author

nightkr commented Jul 21, 2020

Yeah.. either case, any users of the current kube::runtime are going to have some migration work in front of them soon.

nightkr added a commit to nightkr/kube-rs that referenced this issue Jul 21, 2020
@nightkr
Deprecate kube::runtime
381c270 
Fixes kube-rs#281
@nightkr nightkr mentioned this issue Jul 21, 2020
Merged
@clux clux closed this as completed in #282 Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
runtime controller runtime related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate (old) kube::runtime nightkr/kube-rs
2 participants
@clux @nightkr