We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently Api::patch and similar only support --type=merge (i.e. .header("Content-Type", "application/merge-patch+json")).
Api::patch
--type=merge
.header("Content-Type", "application/merge-patch+json")
Would be good to support the 3 strategies.
Note that CRDs doesn't seem to support strategic merge atm, so need better tests. See kubernetes/kubernetes#52772.
The text was updated successfully, but these errors were encountered:
Hi, I'd like to tackle on the issue. How resulting api should look like?
PostParams
PatchParams
dry_run
Sorry, something went wrong.
Hey, awesome! Please go right ahead.
I totally agree with the PatchParams, it's already close to what's in kubernetes under meta/v1#PatchOptions.
Funnily enough though, client-go still passes in an enum and a PatchOptions object 😕 https://github.com/kubernetes/client-go/blob/e6a502f77fded2b9d038629506553ae5bb6e0388/dynamic/client_test.go#L641
Merge pull request #46 from ragne/patch-strategy-support
4360d46
#24 PatchParams and PatchStrategy implementation
No branches or pull requests
Currently
Api::patch
and similar only support--type=merge
(i.e..header("Content-Type", "application/merge-patch+json")
).Would be good to support the 3 strategies.
Note that CRDs doesn't seem to support strategic merge atm, so need better tests. See kubernetes/kubernetes#52772.
The text was updated successfully, but these errors were encountered: