Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derived CustomResource objects do not contain a TypeMeta #170

Closed
nightkr opened this issue Mar 6, 2020 · 2 comments
Closed

Derived CustomResource objects do not contain a TypeMeta #170

nightkr opened this issue Mar 6, 2020 · 2 comments

Comments

@nightkr
Copy link
Member

nightkr commented Mar 6, 2020

This prevents using them to write to the K8s API.
@nightkr
Copy link
Member Author

nightkr commented Mar 6, 2020 •
edited
Loading

k8s-openapi seems to solve that by implementing serde::Serialize manually.. https://docs.rs/k8s-openapi/0.7.1/src/k8s_openapi/v1_17/api/core/v1/secret.rs.html#625-626

@clux
Copy link
Member

clux commented Mar 6, 2020

Ah, we can just flatten TypeMeta in there like we did with the old type. Provided we make some nice way of making a Foo::new() (#167)

@clux clux closed this as completed in fced1f8 Mar 6, 2020
clux added a commit that referenced this issue Mar 6, 2020
@clux
Merge pull request #171 from clux/typemeta-derive
13afed6 
add typemeta for kube-derived CustomResource objects - fixes #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clux @nightkr