Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x-kubernetes-preserve-unknown-fields with type array #314

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix x-kubernetes-preserve-unknown-fields with type array #314

merged 1 commit into from
Mar 4, 2025

Conversation

mnaser
Copy link
Contributor

@mnaser mnaser commented Feb 26, 2025 •
edited
Loading

Closes #313

@mnaser mnaser changed the title Add a failing test Failing test for x-kubernetes-preserve-unknown-fields with type array Feb 26, 2025
@mnaser mnaser mentioned this pull request Feb 26, 2025
Closed
@mnaser
Copy link
Contributor Author

mnaser commented Feb 26, 2025

I dropped my initial test and I believe I changed behaviour of a test that I don't think had the right expectation, a type array for preserve unknown fields feels like it should not be a BTreeMap in this case.

@clux
Copy link
Member

clux commented Feb 27, 2025

I dropped my initial test and I believe I changed behaviour of a test that I don't think had the right expectation, a type array for preserve unknown fields feels like it should not be a BTreeMap in this case.

yeah, i had the same concern.

clux
clux reviewed Feb 27, 2025
View reviewed changes
clux
clux reviewed Feb 27, 2025
View reviewed changes
clux
clux reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks sensible. Thank you!

Looking at this and cross referencing with the previous PR, I think we probably ought to never map-wrap serde_json::Value for unknown fields. I see we do it in a few more places.

happy to merge on green dco/tests tomorrow 😴

@mnaser
Copy link
Contributor Author

mnaser commented Feb 27, 2025

I'll squash my commits to make it easier than going over signing all the other commits :)

@mnaser mnaser changed the title Failing test for x-kubernetes-preserve-unknown-fields with type array Fix x-kubernetes-preserve-unknown-fields with type array Mar 3, 2025
@clux clux merged commit 91929a7 into kube-rs:main Mar 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apiextensionsv1.JSON does not seem to be properly processed
2 participants
@mnaser @clux