Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: direct map of fluentbit securitycontext options #1773

Merged
merged 6 commits into from
Jul 12, 2024
Merged

fix: direct map of fluentbit securitycontext options #1773

merged 6 commits into from
Jul 12, 2024

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Jul 4, 2024 •
edited
Loading

  • Send whole fluentbit SecurityContext to fluentbit, configReloader and bufferVolumeMetrics containers

@aslafy-z aslafy-z marked this pull request as ready for review July 4, 2024 10:44
@pepov
Copy link
Member

pepov commented Jul 4, 2024

@aslafy-z perhaps set the whole spec.Security.SecurityContext directly into c.SecurityContext?

@aslafy-z aslafy-z changed the title fix: add missing fluentbit configmapreloader securitycontext options fix: direct map of fluentbit securitycontext options Jul 4, 2024
@aslafy-z
Copy link
Collaborator Author

aslafy-z commented Jul 4, 2024

I updated the PR, should I map it to buffervolumemetrics container too?

@pepov
Copy link
Member

pepov commented Jul 4, 2024

@aslafy-z I beleive yes, that would be symmetric to what we do with fluentd's bufferVolumeMetrics container as well

@aslafy-z aslafy-z force-pushed the aslafy-z-patch-3 branch from 3083824 to 63cc0a0 Compare July 9, 2024 18:16
@aslafy-z aslafy-z requested a review from pepov July 9, 2024 18:16
@aslafy-z aslafy-z enabled auto-merge (squash) July 9, 2024 18:24
@pepov pepov requested a review from OverOrion July 11, 2024 11:10
@aslafy-z aslafy-z merged commit d3a87fb into master Jul 12, 2024
19 checks passed
@aslafy-z aslafy-z deleted the aslafy-z-patch-3 branch July 12, 2024 08:18
@pepov pepov added the enhancement New feature or request label Aug 13, 2024
@pepov pepov added this to the 4.9 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@OverOrion OverOrion OverOrion approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.
3 participants
@aslafy-z @pepov @OverOrion