Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick fix for #1555 #1569

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Pick fix for #1555 #1569

merged 4 commits into from
Nov 2, 2023

Conversation

kristofgyuracz
Copy link
Contributor

No description provided.

@kristofgyuracz kristofgyuracz changed the base branch from master to release-4.4 November 2, 2023 09:05
@OverOrion OverOrion self-requested a review November 2, 2023 09:07
OverOrion
OverOrion approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the backport! The CI fails because a sign-off is missing, please add that.

@kristofgyuracz kristofgyuracz marked this pull request as ready for review November 2, 2023 12:42
@kristofgyuracz kristofgyuracz merged commit 6636837 into release-4.4 Nov 2, 2023
@kristofgyuracz kristofgyuracz deleted the strings-cherry-pick branch November 2, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@OverOrion OverOrion OverOrion approved these changes

Assignees
No one assigned
Labels
ignore-for-release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristofgyuracz @pepov @OverOrion