refactor: Change url -> dashboardUrl to make a place for another …

…urls like logs url

pkgs/contract/pipeline.go

@@ -25,7 +25,7 @@ type PipelineInfo struct {
 	dateStarted  time.Time
 	status       Status
 	stages       []PipelineStage
-	url          string
+	dashboardUrl string
 	retrievalNum int
 	labels       labels.Labels
 	annotations  labels.Labels
@@ -116,9 +116,9 @@ func (pi PipelineInfo) GetInstanceName() string {
 	return pi.instanceName
 }
 
-// GetUrl returns a URL to some dashboard, where the pipeline could be looked up
-func (pi PipelineInfo) GetUrl() string {
-	return pi.url
+// GetDashboardUrl returns a URL to some dashboard, where the pipeline could be looked up
+func (pi PipelineInfo) GetDashboardUrl() string {
+	return pi.dashboardUrl
 }
 
 // GetName returns a full object name, including namespace
@@ -167,7 +167,7 @@ func PipelineInfoWithLogsCollector(collector func() string) func(pipelineInfo *P
 // PipelineInfoWithUrl is setting optionally a URL pointing to a Pipeline visualization
 func PipelineInfoWithUrl(url string) func(pipelineInfo *PipelineInfo) {
 	return func(pipelineInfo *PipelineInfo) {
-		pipelineInfo.url = url
+		pipelineInfo.dashboardUrl = url
 	}
 }
 
@@ -182,7 +182,7 @@ func NewPipelineInfo(scm JobContext, namespace string, name string, instanceName
 		stages:       stages,
 		labels:       labels,
 		annotations:  annotations,
-		url:          "",
+		dashboardUrl: "",
 		globalCfg:    globalCfg,
 		logs: func() string {
 			return ""

pkgs/feedback/jxscm/receiver.go

@@ -25,7 +25,7 @@ const defaultProgressComment = `
 | {{ $stage.Name }} |  {{ if $stage.Status.IsNotStarted }}Pending{{ else if $stage.Status.IsRunning }}:hourglass_flowing_sand:{{ else if $stage.Status.IsErroredOrFailed }}:x:{{ else if $stage.Status.IsSucceeded }}:white_check_mark:{{ end }}  |
 {{- end }}
 
-{{ if .pipeline.GetUrl }}- [Open in dashboard]({{ .pipeline.GetUrl }}){{ end }}
+{{ if .pipeline.GetDashboardUrl }}- [Open in dashboard]({{ .pipeline.GetDashboardUrl }}){{ end }}
 `
 
 const defaultFinishedComment = `
@@ -39,7 +39,7 @@ The Pipeline finished with status '{{ .pipeline.GetStatus }}' {{ if .pipeline.Ge
 ~~~
 {{ end }}
 
-{{ if .pipeline.GetUrl }}- [Open in dashboard]({{ .pipeline.GetUrl }}){{ end }}
+{{ if .pipeline.GetDashboardUrl }}- [Open in dashboard]({{ .pipeline.GetDashboardUrl }}){{ end }}
 `
 
 const markingBodyPart = `
@@ -250,7 +250,7 @@ func (jx *Receiver) updateCommitStatus(ctx context.Context, cfg config.Data, cli
 				State:  overallStatus,
 				Label:  "Pipeline - " + pipeline.GetFullName(),
 				Desc:   ourStatus.AsHumanReadableDescription(),
-				Target: pipeline.GetUrl(),
+				Target: pipeline.GetDashboardUrl(),
 			},
 		)