Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe it's better to compile TS to ES5 instead of ES2015 #8

Closed
zhanyuzhang opened this issue Aug 13, 2019 · 1 comment · Fixed by ktsn/vue-route-generator#18
Closed

Maybe it's better to compile TS to ES5 instead of ES2015 #8

zhanyuzhang opened this issue Aug 13, 2019 · 1 comment · Fixed by ktsn/vue-route-generator#18

Comments

@zhanyuzhang
Copy link

zhanyuzhang commented Aug 13, 2019 •
edited
Loading

Vue-auto-routing is an awesome thing. However, it includes some ES2015 code, and babel-loader will ignore the files within node_moudles. When we import vue-auto-routing
into our project, it will encounter a problem on older devices, such as iOS8/9, witch not supporting ES2015.
@ktsn ktsn mentioned this issue Aug 15, 2019
Merged
ktsn added a commit that referenced this issue Aug 15, 2019
@ktsn
fix: avoid including ES2015+ code in generated code (#8)
4f6a01e
@ktsn
Copy link
Owner

ktsn commented Aug 15, 2019

tsconfig.json in this repo does not affects generated route code because it is for webpack plugin. I've made a change to vue-route-generator not to include ES2015+ code in generated code. You can try [email protected] for the fix.

@ktsn ktsn reopened this Aug 15, 2019
@ktsn ktsn closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid using es2015+ in generated code ktsn/vue-route-generator
2 participants
@ktsn @zhanyuzhang