Hot reload support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
- Coverage 91.22% 89.2% -2.02%
=========================================
Files 6 6
Lines 729 797 +68
=========================================
+ Hits 665 711 +46
- Misses 50 68 +18
- Partials 14 18 +4 |
ktr0731
force-pushed
the
hotreload
branch
7 times, most recently
from
85dee08 to
72b72ea
Compare
wait for goroutine scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #5
If
WithHotReloadoption is passed toFindorFindMulti, the finder automatically reloads the input slice when its length is changed.For the aspect of performance and usability,
FindandFindMultidon't enable hot reloading by default.TODO
matching.FindAllto pass a part of the slice. The performance got worse when the length of the slice was greater than about 30000 on my environment.