Use locking to solve data race. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Co-authored-by: ktr <[email protected]>
ktr0731
reviewed
Mar 2, 2022
| @@ -615,8 +617,10 @@ func (f *finder) find(slice interface{}, itemFunc func(i int) string, opts []Opt | |||
|
|
|||
| inited := make(chan struct{}) | |||
| if opt.hotReload && rv.Kind() == reflect.Ptr { | |||
| opt.hotReloadLock.Lock() | |||
There was a problem hiding this comment.
Oops, it looks like when the caller uses WithHotReload, it will panic because opt.hotReloadLock is nil (see CI result).
Could you add a nop locker as the default option for backward-compatibility?
Lines 26 to 28 in 81ff9cb
There was a problem hiding this comment.
ya sure. my mistake. My first ever PR, please bear with me :)
There was a problem hiding this comment.
Should be passing this time.
go-fuzzyfinder git:(main) go test -race ./...
ok github.com/ktr0731/go-fuzzyfinder 10.554s
ok github.com/ktr0731/go-fuzzyfinder/matching 0.638s
ok github.com/ktr0731/go-fuzzyfinder/scoring 1.046s
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 85.73% 85.67% -0.06%
==========================================
Files 5 5
Lines 764 775 +11
==========================================
+ Hits 655 664 +9
- Misses 95 97 +2
Partials 14 14 |
ktr0731
approved these changes
Mar 4, 2022
Closed
|
thanks for your time! it is ready to rock in my next side project now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the following does not show data race anymore.