Rename XForwardedHeaderSupport to XForwardedHeadersSupport
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent with `ForwardedHeaderSupport`
|
Merged with the only change 119841c |
dave08
pushed a commit
to dave08/ktor
that referenced
this pull request
Nov 11, 2018
schleinzer
pushed a commit
to schleinzer/ktor
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with
ForwardedHeaderSupport.The alternative is to rename
ForwardedHeaderSupporttoForwardedHeadersSupport.Documentation was wrong because of copy-pasting
ForwardedHeaderSupportadding anX: https://github.com/ktorio/ktorio.github.io/commit/3985523155489d17c8ac623595629e2e1ef5c653But would be nice if they are consistent.