Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7743 Remove redundant configurations for JVM target #4615

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Jan 17, 2025

Subsystem
Infrastructure

Motivation
Cleanup before moving JVM target configs to the build-logic in KTOR-7743.

Solution

  • Remove jetty-apln-boot as it is not necessary anymore
  • Move test logback config to ktor-server-test-base and remove testOutput configuration

@osipxd osipxd self-assigned this Jan 17, 2025
@osipxd osipxd changed the title Remove redundant configurations for JVM target KTOR-7743 Remove redundant configurations for JVM target Jan 17, 2025
Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love seeing the red 🔥

@osipxd osipxd merged commit a870be2 into main Jan 17, 2025
16 checks passed
@osipxd osipxd deleted the osipxd/remove-redundant-jvm-configs branch January 17, 2025 16:21
@osipxd
Copy link
Member Author

osipxd commented Jan 17, 2025

Gotta love seeing the red 🔥

But not in tests :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants