-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ClientLoader.clientTests #4548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad6fd0f
to
15f4fd5
Compare
15f4fd5
to
d0c40e2
Compare
d0c40e2
to
14b7690
Compare
91b5826
to
5f3db18
Compare
b67aba7
to
74eab16
Compare
74eab16
to
ecdf97a
Compare
cf7a037
to
e7ea6d9
Compare
ecdf97a
to
8063190
Compare
8063190
to
3c2236a
Compare
bjhham
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🥇
3c2236a
to
585bf25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Test Infrastructure
Motivation
KTOR-7967 Make client tests independent
Solution
There were several issues with the
clientTests
function:Refactored client tests to apply timeout to each attempt individually.
The main difficulty of this refactor is JS/WasmJS support.
runTest
returnsTestResult
, which is mapped toPromise<Unit>
on JS platform, so we can't just retry the test in a loop. For JS we should usePromise.then { ... }
andPromise.catch { ... }
.Depends on: