Verify sending Content-Type and custom object body via POST #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arnestockmans, @Ribesg, @lamba92, @mister11. The issue was fixed some time ago, could you take a look and confirm that all cases were covered? |
|
@1hsyn1, could you also take a look? |
e5l
force-pushed
the
e5l/body-content-type
branch
from
2b720ac to
587da84
Compare
ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/SerializationTest.kt
Outdated
Show resolved
Hide resolved
ktor-client/ktor-client-tests/common/test/io/ktor/client/tests/SerializationTest.kt
Outdated
Show resolved
Hide resolved
|
Also it is not clear to me how this PR solves #997. I think it is required to add checks for content type that was never specified but I couldn't find a test for the situation where no Content-Type header was specified at all. |
|
That's true. I'll check that case too. |
Ololoshechkin
suggested changes
Jul 16, 2020
e5l
force-pushed
the
e5l/body-content-type
branch
from
587da84 to
a88d4b9
Compare
|
Hey, I fixed the exception message for #997(the behavior is expected, but the message looked confusing) and realized that there are lots of general serialization tests. Could you take a look? |
Ololoshechkin
approved these changes
Jul 21, 2020
e5l
force-pushed
the
e5l/body-content-type
branch
from
78d17f7 to
9c23255
Compare
e5l
force-pushed
the
e5l/body-content-type
branch
from
9c23255 to
a8c91b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #997, #1127