Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory alignment check #1742

Merged
merged 2 commits into from
Jun 4, 2020
Merged

fix memory alignment check #1742

merged 2 commits into from
Jun 4, 2020

Conversation

Louis9902
Copy link
Contributor

Subsystem
ktor-io (posix)

Motivation
i am fairly certain that the alignment checks are just a little typo, if not I'm sorry

Solution
Fixed to binary representation to check if the pointer is dividable by 2,4 or 8

@e5l
Copy link
Member

e5l commented Mar 23, 2020

Hi @Louis9902, thanks for the report. Could you add some tests?

@Louis9902
Copy link
Contributor Author

ups sorry for the two commits I'm still new to git

@Louis9902
Copy link
Contributor Author

@e5l is there something missing?

@e5l
Copy link
Member

e5l commented Apr 3, 2020

Nope. It's ok, I'll merge it soon.

@Louis9902
Copy link
Contributor Author

@e5l just a little reminder 🙈

e5l
e5l approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged

@e5l e5l merged commit d97c19d into ktorio:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis9902 @e5l