Fix behavior of Netty WebSocket closing, server initiates closing in accordance with RFC #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accordance with RFC (#1427).
dmitrievanthony
force-pushed
the
dmitrievanthony/fix-netty-web-socket-connection-closing
branch
from
478fc97 to
1cbb931
Compare
cy6erGn0m
approved these changes
Jan 24, 2020
dmitrievanthony
deleted the
dmitrievanthony/fix-netty-web-socket-connection-closing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server, Netty, WebSockets
Motivation
#1427, https://tools.ietf.org/html/rfc6455#section-5.5.1
According to RFC WebSockets TCP connection closing should be initialized from a server.