Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Local Port Routing Builder #1392

Merged
merged 2 commits into from
Dec 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/*
* Copyright 2014-2019 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license.
*/

package io.ktor.routing

import io.ktor.http.parametersOf
import io.ktor.util.*

/**
* Create a route to match the port on which the call was received.
*
* The selector checks the [io.ktor.request.ApplicationRequest.local] request port,
* _ignoring_ HTTP headers such as "Host" or "X-Forwarded-Host".
* This is useful for securing routes under separate ports.
*
* For multi-tenant applications, you may want to use [io.ktor.routing.port],
* which takes HTTP headers into consideration.
*
* @param port the port to match against
*
* @throws IllegalArgumentException if the port is outside the range of TCP/UDP ports
*/
@KtorExperimentalAPI
fun Route.localPort(port: Int, build: Route.() -> Unit): Route {
require(port in 1..65535) { "Port $port must be a positive number between 1 and 65,535" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entering bike shedding territory here but afaik 0 is also valid. A quick look in InetSocketAddress has:

private static int checkPort(int port) {
        if (port < 0 || port > 0xFFFF)
            throw new IllegalArgumentException("port out of range:" + port);
        return port;
    }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Wikipedia, 0 is reserved. It also adds that:

in programming APIs (not in communication between hosts), [it] requests a system-allocated (dynamic) port

That wouldn't be useful as a filter.


val selector = LocalPortRouteSelector(port)
return createChild(selector).apply(build)
}

/**
* Evaluate a route against the port on which the call was received.
*
* @param port the port to match against
*/
@KtorExperimentalAPI
data class LocalPortRouteSelector(val port: Int) : RouteSelector(RouteSelectorEvaluation.qualityConstant) {
override fun evaluate(context: RoutingResolveContext, segmentIndex: Int) =
if (context.call.request.local.port == port) {
val parameters = parametersOf(LocalPortParameter, port.toString())
RouteSelectorEvaluation(true, RouteSelectorEvaluation.qualityConstant, parameters)
} else {
RouteSelectorEvaluation.Failed
}

companion object {
/**
* Parameter name for [RoutingApplicationCall.parameters] for request host
*/
@KtorExperimentalAPI
const val LocalPortParameter: String = "\$LocalPort"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,45 @@ class RoutingProcessingTest {
}
}

@Test
fun `local port route processing`(): Unit = withTestApplication {
application.routing {
route("/") {
// TestApplicationRequest.local defaults to 80 in the absence of headers
// so connections paths to port 80 in tests should work, whereas other ports shouldn't
localPort(80) {
get("http") {
call.respond("received")
}
}
localPort(443) {
get("https") {
fail("shouldn't be received")
}
}
}
}

// accepts calls to the specified port
handleRequest(HttpMethod.Get, "/http").apply {
assertEquals("received", response.content)
}

// ignores calls to different ports
handleRequest(HttpMethod.Get, "/https").apply {
assertNull(response.content)
}

// I tried to write a test to confirm that it ignores the HTTP Host header,
// but I couldn't get it to work without adding headers, because
// [io.ktor.server.testing.TestApplicationRequest.local] is hard-coded to
// extract the value of those headers.
// (even though, according to docs, it shouldn't; this should be done by `origin`)

// I also tried to create a test listening to multiple ports, but I couldn't get it
// to work because of the same reason above.
}

@Test
fun `routing with tracing`() = withTestApplication {
var trace: RoutingResolveTrace? = null
Expand Down