-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Local Port Routing Builder #1392
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
ktor-server/ktor-server-core/jvm/src/io/ktor/routing/LocalPortRoutingBuilder.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Copyright 2014-2019 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
package io.ktor.routing | ||
|
||
import io.ktor.http.parametersOf | ||
import io.ktor.util.* | ||
|
||
/** | ||
* Create a route to match the port on which the call was received. | ||
* | ||
* The selector checks the [io.ktor.request.ApplicationRequest.local] request port, | ||
* _ignoring_ HTTP headers such as "Host" or "X-Forwarded-Host". | ||
* This is useful for securing routes under separate ports. | ||
* | ||
* For multi-tenant applications, you may want to use [io.ktor.routing.port], | ||
* which takes HTTP headers into consideration. | ||
* | ||
* @param port the port to match against | ||
* | ||
* @throws IllegalArgumentException if the port is outside the range of TCP/UDP ports | ||
*/ | ||
@KtorExperimentalAPI | ||
fun Route.localPort(port: Int, build: Route.() -> Unit): Route { | ||
require(port in 1..65535) { "Port $port must be a positive number between 1 and 65,535" } | ||
|
||
val selector = LocalPortRouteSelector(port) | ||
return createChild(selector).apply(build) | ||
} | ||
|
||
/** | ||
* Evaluate a route against the port on which the call was received. | ||
* | ||
* @param port the port to match against | ||
*/ | ||
@KtorExperimentalAPI | ||
data class LocalPortRouteSelector(val port: Int) : RouteSelector(RouteSelectorEvaluation.qualityConstant) { | ||
override fun evaluate(context: RoutingResolveContext, segmentIndex: Int) = | ||
if (context.call.request.local.port == port) { | ||
val parameters = parametersOf(LocalPortParameter, port.toString()) | ||
RouteSelectorEvaluation(true, RouteSelectorEvaluation.qualityConstant, parameters) | ||
} else { | ||
RouteSelectorEvaluation.Failed | ||
} | ||
|
||
companion object { | ||
/** | ||
* Parameter name for [RoutingApplicationCall.parameters] for request host | ||
*/ | ||
@KtorExperimentalAPI | ||
const val LocalPortParameter: String = "\$LocalPort" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entering bike shedding territory here but afaik 0 is also valid. A quick look in
InetSocketAddress
has:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Wikipedia,
0
is reserved. It also adds that:That wouldn't be useful as a filter.