Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktor 1.0 alpha-1,2,3: StatusPages exception handling misbehaves when exception thrown inside coroutine #646

Closed
marshallpierce opened this issue Oct 15, 2018 · 4 comments
Assignees
Labels

Comments

@marshallpierce
Copy link
Contributor

In short, exception<FooException> {} seems to behave differently when an exception is thrown immediately inside a route's handler lambda vs when it's thrown inside, say, an async coroutine builder in that lambda.

Minimal reproduction: https://bitbucket.org/marshallpierce/ktor-exception-handler-repro/src/master/

@cy6erGn0m cy6erGn0m self-assigned this Oct 15, 2018
@cy6erGn0m cy6erGn0m added the bug label Oct 15, 2018
@marshallpierce
Copy link
Contributor Author

happens with -beta-1 too.

@cy6erGn0m
Copy link
Contributor

Had no change to fix it in beta, sorry.

@marshallpierce
Copy link
Contributor Author

No problem; just keeping the issue up to date so you don't have to bother checking if it's fixed in later versions :)

@cy6erGn0m
Copy link
Contributor

Fix is available in 1.0.0-beta-2

dave08 pushed a commit to dave08/ktor that referenced this issue Nov 11, 2018
schleinzer pushed a commit to schleinzer/ktor that referenced this issue Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants