Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to parse URL #553

Closed
e5l opened this issue Aug 31, 2018 · 2 comments
Closed

Fail to parse URL #553

e5l opened this issue Aug 31, 2018 · 2 comments
Assignees
@e5l
Labels
design enhancement

Comments

@e5l
Copy link
Member

e5l commented Aug 31, 2018

Fail to parse URL when / is missing between hostname and query parameters ?

example: https://www.test.com?test=ok&authtoken=testToken
@e5l e5l self-assigned this Aug 31, 2018
@olbpetersson
Copy link

olbpetersson commented Sep 4, 2018 •
edited
Loading

My team have seen issues where the httpClient throws 'IllegalStateException: Invalid url format' when a queryParam contains '~' (tilde). Tried this on both 0.9.3 and 0.9.4

@e5l e5l added the bug label Sep 4, 2018
@e5l
Copy link
Member Author

e5l commented Sep 4, 2018

The ~ character is not the valid part of URL according to rfc(https://tools.ietf.org/html/rfc3986).
Please consider encoding ~ character for now.

@e5l e5l added design and removed bug labels Sep 4, 2018
e5l added a commit that referenced this issue Sep 14, 2018
@e5l
Rewrite url parser; add long url tests
cc2f6b6 
    resolve #553 #567
soywiz pushed a commit that referenced this issue Oct 1, 2018
@e5l @soywiz
Rewrite url parser; add long url tests
c141515 
    resolve #553 #567
dave08 pushed a commit to dave08/ktor that referenced this issue Nov 11, 2018
@e5l @dave08
Rewrite url parser; add long url tests
e565b64 
    resolve ktorio#553 ktorio#567
schleinzer pushed a commit to schleinzer/ktor that referenced this issue Feb 26, 2019
@e5l
Rewrite url parser; add long url tests
921d91f 
    resolve ktorio#553 ktorio#567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e5l e5l

Labels
design enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e5l @olbpetersson