Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podspec when used as a framework #127

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Fix podspec when used as a framework #127

merged 1 commit into from
Feb 29, 2016

Conversation

SSheldon
Copy link
Contributor

A couple changes in here:

  • Use source_files instead of public_header_files in the subspecs for Recording Advanced and Tools.
  • Include KSCrashReportFilter.h in public_header_files of the Recording subspec.
  • Move Recording Advanced and Tools subspecs from Recording/Advanced to RecordingAdvanced and don't include them in the default subspecs. Moving these subspecs to the top level is the only way to exclude them, as subspecs can't specify default_subspecs ([Specification DSL] default_subspecs is only allowed at root level CocoaPods/Core#305)

Fixes #126
Fixes #125

@SSheldon
Fix podspec when used as a framework.
1585165 
Corrected public headers in the Recording subspecs to fix #126.

The subspecs for Recording Advanced and Tools are no longer included by
default, which fixes #125.
@SSheldon
Copy link
Contributor Author

Oh yeah, testing done:

  • verified things compile from frameworks, including the default KSCrash pod, KSCrash/Recording, KSCrash/RecordingAdvanced
  • verified KSCrash still compiles unaffected as a static library

This was referenced Feb 27, 2016
Open
Closed
Closed
@kstenerud
Copy link
Owner

OK good. I was trying to puzzle out cocoapods but wasn't having much luck.
Thanks!

kstenerud added a commit that referenced this pull request Feb 29, 2016
@kstenerud
Merge pull request #127 from SSheldon/frameworks_advanced
62ddde2 
Fix podspec when used as a framework
@kstenerud kstenerud merged commit 62ddde2 into kstenerud:master Feb 29, 2016
@SSheldon SSheldon deleted the frameworks_advanced branch March 5, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SSheldon @kstenerud