Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.5 #180

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Drop support for Ruby 2.5 #180

merged 1 commit into from
Dec 26, 2021

Conversation

jlduran
Copy link
Collaborator

@jlduran jlduran commented Apr 7, 2021

  • Ruby 2.5 is EOL
  • Fix some RuboCop suggestions

@jlduran
Copy link
Collaborator Author

jlduran commented Apr 7, 2021

jruby builds on GitHub are failing because of endless ranges. I'll take a look at it some other time.

@jlduran jlduran marked this pull request as draft April 7, 2021 15:23
@jlduran jlduran self-assigned this Apr 7, 2021
@coveralls
Copy link

coveralls commented Apr 7, 2021

Coverage Status

Coverage increased (+0.0003%) to 99.906% when pulling 02d6204 on ruby25-eol into 4050aae on master.

@jlduran
Copy link
Collaborator Author

jlduran commented Apr 11, 2021

GitHub's jruby is loading parser/current as parser/ruby25 instead of >= parser/ruby26. I'll re-run once they fix it.

@jlduran jlduran marked this pull request as ready for review December 26, 2021 17:33
RuboCop:
- Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
- Style/MapToHash: Pass a block to to_h instead of calling map.to_h.
@jlduran jlduran merged commit 785ed8b into master Dec 26, 2021
@jlduran jlduran deleted the ruby25-eol branch December 26, 2021 17:38
jlduran added a commit that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants