Readable specs #16
Closed
Readable specs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merge this changes to branch 'feature/readable_tests'. Please review that branch and get your proposals here. |
|
YML-driven examples are much better! Great stuff. Closing this pull request. |
|
I think it's not ideal way. Maybe yml files could be in better place or maybe helper and shared example could be more understandable. |
|
I think it's a huge improvement over what you have now. I take a pragmatic approach to these things... |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that testing against the locale file misses the point. If the locale file had "foobar" instead of "one", the tests would still pass, but the code would be broken.
Rewrote the tests to be checking against the actual expected result.