Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add developer instructions to README.md #85

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Feb 17, 2023

Motivation

It can be challenging to figure out how to get a development environment setup especially for folks who have not worked with Maven before.

Modifications

Adding some information of development workflow and project setup for working with an IDE.

Result

Hopefully a less frustrating on-boarding experience.

/cc @rafvasq

@ckadner ckadner requested review from rafvasq and njhill February 17, 2023 01:58
@njhill njhill requested review from ScrapCodes and removed request for njhill February 17, 2023 23:20
@rafvasq
Copy link
Member

rafvasq commented Feb 17, 2023

@ckadner Do you think we could make a docs directory and start it with this developer-guide.md? It'd probably be beneficial to start documenting more aspects of this framework as we continue to develop here.

Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Copy link
Member Author

ckadner commented Feb 18, 2023

@ckadner Do you think we could make a docs directory and start it with this developer-guide.md? It'd probably be beneficial to start documenting more aspects of this framework as we continue to develop here.

I think the idea was to keep all (or most) of the documentation in one place inside the modelmesh-serving repo's docs folder.

But I do agree it makes sense to have a separate document for development related information -- as opposed to the "consumer-oriented" general info in the main README.md.

@ckadner ckadner requested review from njhill and removed request for njhill February 18, 2023 01:19
@ckadner ckadner added the documentation Improvements or additions to documentation label Feb 18, 2023
rafvasq
rafvasq previously approved these changes Feb 21, 2023
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ckadner, it's already proved helpful for me and acts as a great starter doc that we can amend over time.

developer-guide.md Outdated Show resolved Hide resolved
@ScrapCodes
Copy link
Contributor

ScrapCodes commented Feb 24, 2023

Hi @ckadner ! the guide has been useful to me as is ( i have left comments for your consideration only), however, I have not been successful in getting the newly built and pushed image to be updated to existing modelmesh-controller deployment.

@rafvasq
Copy link
Member

rafvasq commented Oct 2, 2023

@ckadner is there anything you'd like to change here based on @ScrapCodes comments/any additions since you opened this? Or can we merge this as a good starting point for a developer doc?

@ckadner
Copy link
Member Author

ckadner commented Oct 6, 2023

@ckadner is there anything you'd like to change here based on @ScrapCodes comments/any additions since you opened this? Or can we merge this as a good starting point for a developer doc?

Hi @rafvasq -- I will take another pass and see how I can best address the review comments

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner requested a review from rafvasq October 10, 2023 02:18
rafvasq

This comment was marked as resolved.

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit. Thanks @ckadner.

developer-guide.md Outdated Show resolved Hide resolved
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Copy link
Member Author

ckadner commented Oct 10, 2023

@rafvasq -- I pushed a last set of updates. Thanks for your review!

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq merged commit 0ee6de6 into kserve:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants