-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add developer instructions to README.md #85
Conversation
Signed-off-by: Christian Kadner <[email protected]>
@ckadner Do you think we could make a |
Signed-off-by: Christian Kadner <[email protected]>
I think the idea was to keep all (or most) of the documentation in one place inside the But I do agree it makes sense to have a separate document for development related information -- as opposed to the "consumer-oriented" general info in the main README.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ckadner, it's already proved helpful for me and acts as a great starter doc that we can amend over time.
Hi @ckadner ! the guide has been useful to me as is ( i have left comments for your consideration only), however, I have not been successful in getting the newly built and pushed image to be updated to existing modelmesh-controller deployment. |
@ckadner is there anything you'd like to change here based on @ScrapCodes comments/any additions since you opened this? Or can we merge this as a good starting point for a developer doc? |
Hi @rafvasq -- I will take another pass and see how I can best address the review comments |
Signed-off-by: Christian Kadner <[email protected]>
2bbec43
to
d01c791
Compare
Signed-off-by: Christian Kadner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit. Thanks @ckadner.
Signed-off-by: Christian Kadner <[email protected]>
@rafvasq -- I pushed a last set of updates. Thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
It can be challenging to figure out how to get a development environment setup especially for folks who have not worked with Maven before.
Modifications
Adding some information of development workflow and project setup for working with an IDE.
Result
Hopefully a less frustrating on-boarding experience.
/cc @rafvasq