fix: Disable FIPS for java #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation Modelmesh can have problems in FIPS-enabled environments due to restrictions placed on TLS keystores. Modifications Disable FIPS in RedHat OpenJDK via the -Dcom.redhat.fips=false command line arg, unless already specified in the CUSTOM_JVM_ARGS env var. Result Modelmesh will continue to work in FIPS-enabled environments. Signed-off-by: Nick Hill <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hopefully we can find a solution that works without disabling FIPS in the future, but, for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modelmesh can have problems in FIPS-enabled environments due to restrictions placed on TLS keystores.
Modifications
Disable FIPS in RedHat OpenJDK via the
-Dcom.redhat.fips=falsecommand line arg, unless already specified in theCUSTOM_JVM_ARGSenv var.Result
Modelmesh will continue to work in FIPS-enabled environments.
Signed-off-by: Nick Hill [email protected]