Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to use Java 17 #33

Merged
merged 1 commit into from
Jun 9, 2022
Merged

chore: Update to use Java 17 #33

merged 1 commit into from
Jun 9, 2022

Conversation

njhill
Copy link
Member

@njhill njhill commented Apr 28, 2022

Motivation

Java 17 is the latest LTS release and contains various performance improvements, particularly related to GC.

Modifications

  • Update github actions build to use java 17 temurin distribution.
  • Update Dockerfile to install/configure openjdk 17 instead of 11
  • Remove unnecessary logic from Dockerfile related to installing headless jdk
  • Add bouncycastle library to pom.xml, now needed for generating self-signed certs

Result

Hopefully some performance improvement, ready to make use of newer java features.

Motivation

Java 17 is the latest LTS release and contains various performance improvements, particularly related to GC.

Modifications

- Update github actions build to use java 17 temurin distribution.
- Update Dockerfile to install/configure openjdk 17 instead of 11
- Remove unnecessary logic from Dockerfile related to installing headless jdk
- Add bouncycastle library to pom.xml, now needed for generating self-signed certs

Result

Hopefully some performance improvement, ready to make use of newer java features.

Signed-off-by: Nick Hill <[email protected]>
@njhill njhill marked this pull request as ready for review June 9, 2022 15:00
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @njhill! Good to see that the upgrade was pretty straightforward.
/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, pvaneck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 74a82df into main Jun 9, 2022
@njhill njhill deleted the java17 branch August 2, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants