Internal sync #20
Merged
Internal sync #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure that rolling updates are staggered, to give more time for DNS of now pods to propagate to clients before all existing pods are terminated. Signed-off-by: Nick Hill <[email protected]>
Motivation Model-mesh contains remediation logic for when models are unexpectedly not found in the model server container. This can happen if the model server container restarts for example due to OOM. However, it relies on the model server to return grpc error code NOT_FOUND in this case. Unfortunately, MLServer currently returns INVALID_ARGUMENT which isn't the most appropriate code. This means that if MLServer restarts, previously loaded models do not properly recover. Modifications - Add logic to detect MLServer not-found responses in SidecarModelMesh and treat as NOT_FOUND (following what was previously done for Triton inference server) - Add unit test Result Already-loaded models should recover properly following MLServer restarts. Signed-off-by: Nick Hill <[email protected]>
|
/hold |
pvaneck
approved these changes
Feb 18, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhill, pvaneck The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully be the last "internal sync" PR for this repo, we have almost completed rebasing our internal dev on the KServe fork.