fix: Fix code errors reported by golangci-lint

[pugangxa]

Motivation

In #53 reported some issues, checked and fixed the ones that are code errors

Modifications

Fix bug

Result

The code error is fixed, but

• The field alignment is not fixed, not sure whether it's needed and it may have potential impact, maybe just change the golangci-lint rule to ignore it?
• Does not upgrade golangci-lint to 1.42.1 and golang to 1.7 since as mentioned it will be looked separately.

[pugangxa]

Let me know if we want to address the field alignment issue or golang upgrade issue.

[pvaneck]

Thanks! Seems like the unusedwrite lint errors are pretty notable and should be caught by the linter. I'm thinking it's worthwhile to update the golangci-lint version to the latest.

As for fieldalignment errors, I'm not sure if the gain from reordering struct fields is worth it here. I know that some of our structs have fields organized in a specific matter based on topic/function. Checking the existing .golangci.yaml, we have the maligned check disabled which is what fieldalignment replaced in the newer golangci-lint versions. So maybe we also disable govet fieldalignment check?

@njhill WDYT?

[pugangxa]

Upgraded golangci and disabled fieldalignment.

[pvaneck]

Thanks!
/lgtm

[njhill]

Thanks @pugangxa, and sorry I missed this earlier. These are legit bugs.

@pvaneck I agree with disabling the fieldalignment checks.

[njhill]

May as well avoid the struct copy altogether and also change to:

			for i, _ := range container.VolumeMounts {
				if container.VolumeMounts[i].Name == etcdVolume {

[pugangxa]

OK, addressed.

[njhill]

Thanks @pugangxa!

For future reference, it's best not to modify existing commits that have already been reviewed (apart from rebasing them), just push new commits.

[kserve-oss-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, pugangxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njhill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[njhill]

/lgtm