Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename webhook (HPA) #415

Merged
merged 1 commit into from
Aug 4, 2023
Merged

chore: Rename webhook (HPA) #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/default/webhookcainjection_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: servingruntime.serving.kserve.io
name: modelmesh-servingruntime.serving.kserve.io
annotations:
cert-manager.io/inject-ca-from: $(CERTIFICATE_NAMESPACE_PLACEHOLDER)/$(CERTIFICATE_NAME_PLACEHOLDER)
2 changes: 1 addition & 1 deletion config/webhook/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: servingruntime.serving.kserve.io
name: modelmesh-servingruntime.serving.kserve.io
webhooks:
- admissionReviewVersions:
- v1
Expand Down
4 changes: 2 additions & 2 deletions scripts/self-signed-ca.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ The following flags are optional.
--service Service name of webhook. Default: modelmesh-webhook-server-service
--namespace Namespace where webhook service and secret reside. Default: model-serving
--secret Secret name for CA certificate and server certificate/key pair. Default: modelmesh-webhook-server-cert
--webhookName Name for the mutating and validating webhook config. Default: servingruntime.serving.kserve.io
--webhookName Name for the mutating and validating webhook config. Default: modelmesh-servingruntime.serving.kserve.io
--webhookDeployment deployment name of the webhook controller. Default: modelmesh-controller
EOF
exit 1
Expand Down Expand Up @@ -70,7 +70,7 @@ done
[ -z ${secret} ] && secret=modelmesh-webhook-server-cert
[ -z ${namespace} ] && namespace=model-serving
[ -z ${webhookDeployment} ] && webhookDeployment=modelmesh-controller
[ -z ${webhookName} ] && webhookName=servingruntime.serving.kserve.io
[ -z ${webhookName} ] && webhookName=modelmesh-servingruntime.serving.kserve.io
[ -z ${service} ] && service=modelmesh-webhook-server-service
webhookDeploymentName=${webhookDeployment}
webhookConfigName=${webhookName}
Expand Down