Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add manual trigger to run build/push action #404

Merged
merged 2 commits into from
Jul 21, 2023
Merged

chore: Add manual trigger to run build/push action #404

merged 2 commits into from
Jul 21, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jul 21, 2023

Motivation

Sometimes the GitHub action to push images does not get triggered despite apparently all filter conditions being met.

Modifications

Add on: workflow_dispatch to build/push action workflow.

To trigger a workflow in a repository, the user has to be a collaborator with Write permission in the repository. External users can’t trigger workflows in the repository.

Result

TBD

ckadner added 2 commits July 21, 2023 09:58
Use 'workflow_dispatch' as manual GitHub action event trigger.

Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner requested a review from rafvasq July 21, 2023 17:05
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner, rafvasq
To complete the pull request process, please assign tjohnson31415 after the PR has been reviewed.
You can assign the PR to them by writing /assign @tjohnson31415 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner
Copy link
Member Author

ckadner commented Jul 21, 2023

Thanks @rafvasq

@ckadner ckadner merged commit da2f25a into main Jul 21, 2023
@ckadner ckadner deleted the latest branch July 21, 2023 17:27
ckadner added a commit that referenced this pull request Jul 24, 2023
Sometimes the GitHub action to push images does not get triggered
despite apparently all filter conditions being met.

Signed-off-by: Christian Kadner <[email protected]>
(cherry picked from commit da2f25a)
ckadner added a commit that referenced this pull request Jul 24, 2023
Sometimes the GitHub action to push images does not get triggered
despite apparently all filter conditions being met.

Signed-off-by: Christian Kadner <[email protected]>
(cherry picked from commit da2f25a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants