Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Dockerfile packages (#291) #298

Merged
merged 1 commit into from
Jan 8, 2023
Merged

chore: Update Dockerfile packages (#291) #298

merged 1 commit into from
Jan 8, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented Jan 7, 2023

Modifications

  1. Update the ModelMesh Controller image to use the UBI 8.7 minimal base image
  2. Updated Go version to the latest fix pack version.

Signed-off-by: JasmondL [email protected]
Authored-by: JasmondL [email protected]
Co-authored-by: JasmondL [email protected]

#### Motivation
Fix vulnerabilities in the ModelMesh Controller image.

#### Modifications
1. Remove dependencies to any packages in the runtime. 
2. Updated Go version to the latest version.

#### Result 
The feature is functionally working, I have tested it on my own cluster.

Signed-off-by: JasmondL <[email protected]>

Co-authored-by: JasmondL <[email protected]>
@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner
To complete the pull request process, please assign pvaneck after the PR has been reviewed.
You can assign the PR to them by writing /assign @pvaneck in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner requested review from njhill and removed request for pvaneck January 7, 2023 01:30
@ckadner ckadner changed the title Update Dockerfile packages (#291) chore: Update Dockerfile packages (#291) Jan 7, 2023
@njhill njhill merged commit 3ab3e35 into release-0.10 Jan 8, 2023
kserve-oss-bot pushed a commit that referenced this pull request Jan 11, 2023
#### Motivation

When we create a new release we need the GitHub actions to run for 
- Lint
- Unit test
- FVT
- Image build and push

#### Modifications

Update the Github workflow definitions to include any `release-..` branches.

#### Result

The GitHub action run on PR and pushed to the release branch.

As can be seen in this PR targeting the `release-0.10` branch:
#298

---

**Note**: same (intended) changes as in PR #299 -- but without the merge commits

/cc @njhill @rafvasq 
/assign @njhill 

Signed-off-by: Christian Kadner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants