chore: Fix error in verify_doc_links.py script
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In its current version the verify-doc-links script excludes any URLs that contain a colon character ":" which was meant to exclude any local URLs with a port like ":8008" but instead it excludes any URLs that start with "http:" or "https:" Signed-off-by: Christian Kadner <[email protected]>
njhill
approved these changes
Sep 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
hdefazio
pushed a commit
to hdefazio/modelmesh-serving
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Spolti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In its current version the
verify_doc_links.pyscript excludes any URLs that contain a colon:character.This was meant to exclude any local URLs with a port like "
:8008". Instead it excludes any URLs that start with "http:" or "https:". The "rookie" who created that script! 🙄Modifications
Remove the ":" from the list of patterns to identify URLs that should be excluded from the link verification.
Result
220 links found instead of 211 before.