docs: Add tls configuration docs #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: PRASHANT GUPTA <[email protected]> Co-authored-by: Nick Hill <[email protected]> Co-authored-by: JOE RUNDE <[email protected]> Signed-off-by: Paul Van Eck <[email protected]>
|
Most original authors (from what I could tell) are listed as co-authors in the commit. Also, I think it should be fine to leave some of the OpenShift specific instructions since we do have some OpenShift users. However, we should also create instructions for using a Kubernetes Ingress resource with ModelMesh (as opposed to an OpenShift Route). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chinhuang007, pvaneck The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pvaneck
added a commit
to pvaneck/modelmesh-serving
that referenced
this pull request
Jun 30, 2022
Surface some internal TLS configuration documentation externally. Signed-off-by: Paul Van Eck <[email protected]> Co-authored-by: PRASHANT GUPTA <[email protected]> Co-authored-by: Nick Hill <[email protected]> Co-authored-by: JOE RUNDE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface some internal TLS configuration documentation externally.