Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable ModelMetadata endpoint #164

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Jun 9, 2022

Motivation

Enable users to use the KServe v2 ModelMetadata endpoint with Triton and MLServer ServingRuntimes.

Modifications

  • ModelMetadata added to dataplane config in controller.
  • Some functional tests were added to test the newly exposed endpoint.

Result

Users can send gRPC requests to the ModelMetadata endpoint. Primarily useful with Triton as MLServer only seems to return the name of the model.

Partially-Closes: #136

@pvaneck
Copy link
Member Author

pvaneck commented Jun 9, 2022

/hold

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvaneck!

@pvaneck
Copy link
Member Author

pvaneck commented Jun 13, 2022

/unhold

fvt/fvtclient.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pvaneck !

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chinhuang007, njhill, pvaneck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chinhuang007
Copy link
Contributor

/lgtm

@kserve-oss-bot kserve-oss-bot merged commit 5c47211 into kserve:main Jun 13, 2022
@pvaneck pvaneck deleted the modelmetadata branch June 15, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ModelMetadata endpoint support
4 participants