You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? If so, please describe.
We have a custom webhook to validate and mutate the actual pod created by the ServingRuntime based on the labels/annotations, for example, mutate resources limit and validate user info added in the annotations.
However, currently the ServingRuntime will not pass its own labels/annotations to the deployment/pod and there is no field in the spec to provide labels/annotations as well. The runtimePodLabels and runtimePodAnnotations in model-serving-config are system-wide configurations but our use case is setting the value per ServingRuntime.
Describe your proposed solution
pass labels/annotations in the ServingRuntime's metadata to the deployment spec.template.metadata, or
add labels and annotations fields in the ServingRuntime spec and pass them to the deployment spec.template.metadata.
Describe alternatives you have considered
Additional context
The text was updated successfully, but these errors were encountered:
@lizzzcai this sounds very reasonable and would be pretty trivial to implement. We should definitely follow the second proposal though, specifically to add annotations and labels fields to the ServingRuntimePodSpec.
This would apply similarly to single-model runtimes so would also require a small update to the original kserve controller.
…ec to runtime Pod (#271)
Motivation
fix#224
Modifications
1. Update servingruntime CRDs
2. pass labels and annotations from ServingRuntimePodSpec to deployment.Spec.Template and add tests
3. upgrade dependencies
Result
The feature is functionally working, I have tested it manually.
The user is able to pass labels and annotations from servingruntime. It will overwrite labels and annotations from the config.
Signed-off-by: Lize Cai <[email protected]>
Is your feature request related to a problem? If so, please describe.
We have a custom webhook to
validate
andmutate
the actual pod created by the ServingRuntime based on the labels/annotations, for example, mutate resources limit and validate user info added in the annotations.However, currently the ServingRuntime will not pass its own labels/annotations to the deployment/pod and there is no field in the spec to provide labels/annotations as well. The
runtimePodLabels
andruntimePodAnnotations
in model-serving-config are system-wide configurations but our use case is setting the value per ServingRuntime.Describe your proposed solution
spec.template.metadata
, orspec.template.metadata
.Describe alternatives you have considered
Additional context
The text was updated successfully, but these errors were encountered: