-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile documentation #50
Conversation
Signed-off-by: ddelange <[email protected]>
cc @ckadner |
Signed-off-by: ddelange <[email protected]>
Signed-off-by: ddelange <[email protected]>
Signed-off-by: ddelange <[email protected]>
friendly ping @ckadner :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ddelange -- appologies for the long wait.
I have a few minor wording suggestions and a regex improvement :-)
Signed-off-by: ddelange <[email protected]>
Signed-off-by: ddelange <[email protected]>
kserve/modelmesh-runtime-adapter#50 Signed-off-by: ddelange <[email protected]>
kserve/modelmesh-runtime-adapter#50 Signed-off-by: ddelange <[email protected]>
@ckadner done in all three PRs 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ddelange
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ckadner, ddelange The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
#38 (comment)
Modifications
Add help texts
Result